Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: split Contacts.ts file and its tests into separate files for every function #33698

Merged
merged 3 commits into from
Oct 22, 2024
Merged

chore: split Contacts.ts file and its tests into separate files for every function #33698

merged 3 commits into from
Oct 22, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Oct 21, 2024 •
edited
Loading

Proposed changes (including videos or screenshots)

I'm splitting the Contacts.ts file into a different file for each function. The only function that I actually changed was registerContact (renamed contactId to visitorId and replaced meteor/check with an inline assertion). Everything else is unchanged other than the function locations.

I also added a few new unit tests.

Issue(s)

Steps to test or reproduce

Further comments

The failing UI test is failing in the base branch.

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 21, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 09edde8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33698/
on branch gh-pages at 2024-10-21 22:09 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.83893% with 36 lines in your changes missing coverage. Please review.

Project coverage is 75.39%. Comparing base (04e7f06) to head (fa70e74).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #33698      +/-   ##
==========================================================
+ Coverage                   74.51%   75.39%   +0.88%     
==========================================================
  Files                         485      491       +6     
  Lines                       21361    21155     -206     
  Branches                     5407     5344      -63     
==========================================================
+ Hits                        15917    15950      +33     
+ Misses                       4796     4568     -228     
+ Partials                      648      637      -11
Flag Coverage Δ
unit 75.39% <75.83%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc force-pushed the chore/sci/split-contacts-files branch from 6e5180c to 6fe3dfb Compare October 22, 2024 11:08
@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review October 22, 2024 12:36
@pierre-lehnen-rc pierre-lehnen-rc requested review from a team as code owners October 22, 2024 12:36
dougfabris
dougfabris approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend perfect

@pierre-lehnen-rc pierre-lehnen-rc merged commit b4acee8 into feat/single-contact-id Oct 22, 2024
4 of 5 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the chore/sci/split-contacts-files branch October 22, 2024 16:21
dougfabris pushed a commit that referenced this pull request Oct 22, 2024
@pierre-lehnen-rc @dougfabris
chore: split Contacts.ts file and its tests into separate files for e…
e285a43 
…very function (#33698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougfabris dougfabris dougfabris approved these changes

@tapiarafael tapiarafael tapiarafael approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierre-lehnen-rc @tapiarafael @dougfabris